Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh issue 681 pt2 #708

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Gh issue 681 pt2 #708

merged 3 commits into from
Jul 27, 2023

Conversation

JanMarvin
Copy link
Owner

In addition to #681.

  • remove deprecated function read_sheet_names() (it looks horrible and was deprecated in 0.7?)
  • make wb_get_sheet_name() internal. There is a wrapper function wb_get_sheet_names() which is just an s away.
  • change xlsx_file to file, another option I was considering is wb. Because file can be a file or a workbook and wb kinda reflects that. Thoughts?

…wrapper function the user should use is wb_get_sheet_names()
@JanMarvin JanMarvin merged commit a0f62ef into main Jul 27, 2023
@JanMarvin JanMarvin deleted the gh_issue_681_pt2 branch July 27, 2023 18:13
@sjewo
Copy link
Contributor

sjewo commented Aug 31, 2023

My code broke because of the removed read_sheet_names() function and it took some time to find out what the problem was.

So I leave this here for further reference:

# replacement for read_sheet_names
wb_get_sheet_names(wb_load(filepath))

@JanMarvin
Copy link
Owner Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants