Add openxlsx2.na.strings option #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMarvin
reviewed
Mar 13, 2024
|
I see why you want it this way. Since I have no preference, I’m equally happy with this PR! |
olivroy
changed the title
olivroy
commented
Mar 14, 2024
olivroy
commented
Mar 14, 2024
|
Looks good to me! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about something more like this.
I strongly feel about not having an option overriding a parameter passed (other than the default)
If option is set and na.string is not supplied: use the option
If option is set and na.string is supplied: use na.strings
If option is not set and na.string is not use default.
Amends to #473 and addresses #20