Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery3 compatibility #162

Closed
wants to merge 1 commit into from
Closed

jQuery3 compatibility #162

wants to merge 1 commit into from

Conversation

spdawson
Copy link

Do not call complete on object returned from jQuery.ajax; see #161

@existent-ltd
Copy link

This issue is also affecting us; any chance of getting this PR merged, and a new gem version released?

@spdawson
Copy link
Author

spdawson commented Nov 9, 2016

Is there anything I can do to get this merged?

@clairity
Copy link

thanks @spdawson ! manually implementing this change made remotipart work for me (rails 5.0.1, jquery3).

@iarie
Copy link

iarie commented Feb 28, 2017

@spdawson i'am using your solution, thanks! This bug almost made me quit the idea of using remotipart :/
ps: rails 5.0.1/ JQuery3

@penapono
Copy link

I'm getting a SyntaxError: missing ; before statement, any hints on this? Thanks

@kayla-glick
Copy link

kayla-glick commented Apr 1, 2018

@JangoSteve @mshibuya
This is a pretty glaring issue nearly 2 years after the release of jQuery 3. If @spdawson 's solution fixes the problem, can this please be merged soon, or at least reviewed? This PR has been up for 1 1/2 years and this issue is affecting many users of remotipart.

Thanks again @spdawson for your solution. I will be using your fork for now as well.

@JangoSteve
Copy link
Owner

You're right! I'll take a look, merge it, and release a new version.

@mshibuya mshibuya closed this in 5604d30 Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants