Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture stitcher: rewrite box packing and fix different resolution stitching #539

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

mchorse
Copy link
Contributor

@mchorse mchorse commented May 19, 2024

No description provided.

@mchorse
Copy link
Contributor Author

mchorse commented May 21, 2024

Oh... I didn't realize that the new commit will be added to this PR. I hope it's not a big deal that two plugin updates are in a single PR?

@JannisX11
Copy link
Owner

Yeah, please only update one plugin per PR. You can create different PRs on the same repository by using different branches.

@mchorse
Copy link
Contributor Author

mchorse commented May 26, 2024

Yeah, please only update one plugin per PR. You can create different PRs on the same repository by using different branches.

I fixed it.

@JannisX11
Copy link
Owner

Is it intentional that box UV support was removed?

@mchorse
Copy link
Contributor Author

mchorse commented May 31, 2024

Is it intentional that box UV support was removed?

It appears not, I guess I removed it during implementation and forgot to reimplement it once I got per-face working. 😅

@JannisX11
Copy link
Owner

Per-element box UV is not working. Might not have worked before either.

@mchorse
Copy link
Contributor Author

mchorse commented Jun 12, 2024

Per-element box UV is not working. Might not have worked before either.

I wasn't aware of its existence. I'll try making it work.

@JannisX11 JannisX11 merged commit 494bd5b into JannisX11:master Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants