Add app config for absolute texture paths #2489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Kage-Yami
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
absolute_texture_pathsapp setting that controls whether or not the$.textures[].pathfield is written to.bbmodelproject files.Piggy-backed off the existing functionality to remove the field, which seems to exist for sharing project files, but mimicked the way the
embed_texturessetting is checked for just above it.The surrounding settings in
js/interface/settings.jsseem to be column-aligned, so I updated the other settings to match the new alignment required for this slightly-longer setting name.Based on looking at the non-English translation files, I assumed English stubs should be included in each language's file, so did so.
This aims to partially resolve #1322 - it doesn't address per-project settings, but it resolves the overall issue in the same way as has been done previously for embedding texture data.