Skip to content

Commit

Permalink
Add some commentary to ScalaPluginBootstrapContext and link to some d…
Browse files Browse the repository at this point in the history
…ocumentation.
  • Loading branch information
Jan Boerman committed Feb 12, 2024
1 parent 1ef7a5f commit e1da717
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,17 @@

public class ScalaPluginBootstrapContext extends ScalaPluginProviderContext implements BootstrapContext {

//TODO should perhaps use PaperLifecycleEventManager instead, since it contains some magic knowledge about the handlerConfiguration.
//TODO when should our booleanSupplier return false tho? I guess when all ScalaPlugins finished loading.
//TODO check https://gist.github.com/Machine-Maker/8e3fc6063c98e81cae7cee1ac230936f
private final LifecycleEventManager<BootstrapContext> lifecycleEventManager = new LifecycleEventManager<BootstrapContext>() {
@Override
public void registerEventHandler(
@NotNull LifecycleEventHandlerConfiguration<? super BootstrapContext> handlerConfiguration) {
//TODO this is currently not called. when should this be called? should it be called at all?
}
};



public ScalaPluginBootstrapContext(File pluginJarFile, ScalaPluginDescription description) {
super(pluginJarFile, description);
}
Expand Down

0 comments on commit e1da717

Please sign in to comment.