Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.CodeAnalysis.VisualBasic from 1.0.0 to 3.1.0 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 3, 2019

Bumps Microsoft.CodeAnalysis.VisualBasic from 1.0.0 to 3.1.0.

Release notes

Sourced from Microsoft.CodeAnalysis.VisualBasic's releases.

VS.Toolset.Roslyn.1.1.0-beta1-20150825-02

No release notes provided.

Visual Studio 2019 Version 16.0

Build Branch: dev16.0-vs-deps
Internal ID: Roslyn-Signed_20190320.1

VS.Toolset.Roslyn.1.1.0-beta1-20150727-01

No release notes provided.

Changelog

Sourced from Microsoft.CodeAnalysis.VisualBasic's changelog.

API Breaking Changes

Version 1.1.0

Removed VisualBasicCommandLineParser.ctor

During a toolset update we noticed the constructor on VisualBasicCommandLineParser was public. This in turn made many of the protected members of CommandLineParser a part of the API surface as it gave external customers an inheritance path.

It was never the intent for these members to be a part of the supported API surface. Creation of the parsers is meant to be done via the Default singleton properties. There seems to be little risk that we broke any customers here and hence we decided to remove this API.

PR: #4169

Changed Simplifier methods to throw ArgumentNullExceptions

Changed Simplifier.ReduceAsync, Simplifier.ExpandAsync, and Simplifier.Expand methods to throw ArgumentNullExceptions if any non-optional, nullable arguments are passed in. Previously the user would get a NullReferenceException for synchronous methods and an AggregateException containing a NullReferenceException for asynchronous methods.

PR: #5144

Version 1.3.0

Treat a method marked with both public and private flags as private

The scenario is loading an assembly where some methods, fields or nested types have accessibility flags set to 7 (all three bits set), which mean public AND private.
After the fix, such flags are loaded to mean private.
The compat change is we’re trading a compile-time success and runtime failure (native compiler) against a compile-time error (restoring the behavior of v1.2).

Details below:

  • The native compiler successfully compiles the method and field case (those only yield runtime error System.TypeLoadException: Invalid Field Access Flags) and reported an accessibility error on the nested type.
  • The 1.2 compiler generated errors:
error BC30390: 'C.Private Overloads Sub M()' is not accessible in this context because it is 'Private'.
error BC30389: 'C.F' is not accessible in this context because it is 'Private'.
error BC30389: 'C.C2' is not accessible in this context because it is 'Protected Friend'.
error BC30390: 'C2.Private Overloads Sub M2()' is not accessible in this context because it is 'Private'.
  • The 1.3 compiler crashes.
  • After fix, the same errors as 1.2 are generated again.

PR: #11547

Don't emit bad DateTimeConstant, and load bad BadTimeConstant as default value instead

The change affects compatibility in two ways:

  • When loading an invalid DateTimeConstant(-1), the compiler will use default(DateTime) instead, whereas the native compiler would produce code that fails to execute.
  • DateTimeConstant(-1) will still count when we check that you don’t specify two default values. The compiler will produce an error, instead of succeeding (and producing IL with two attributes).

PR: #11536

Commits
  • 9d80dea Merge pull request #35740 from dotnet/merges/release/dev16.1-to-release/dev16...
  • 1e993cf Merge pull request #35733 from jasonmalinowski/fix-naming-style-ordering
  • 7ac1772 Ensure we give .editorconfig keys in the same order as in the file
  • 7f4a080 Rename EditorConfigStorageLocationTests since it was really testing something...
  • e38a60d Merge pull request #35712 from dotnet/merges/release/dev16.1-to-release/dev16...
  • 04cca4a Merge pull request #35664 from gafter/dev16.1-35584
  • 794651d Adjust tests per code review.
  • efa48d2 Fix bug where pattern-matching treats a type parameter as if it is a referenc...
  • 33cfe1a Merge pull request #35657 from dotnet/merges/release/dev16.1-to-release/dev16...
  • 9361041 Merge pull request #35616 from genlu/FixCommit
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jul 3, 2019
@dependabot-preview dependabot-preview bot force-pushed the dependabot/nuget/Microsoft.CodeAnalysis.VisualBasic-3.1.0 branch from 438d576 to ea28865 Compare July 13, 2019 18:13
@JayBazuzi
Copy link
Owner

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/nuget/Microsoft.CodeAnalysis.VisualBasic-3.1.0 branch from ea28865 to 89c8289 Compare July 13, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant