-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise exceptions control #212
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for the work! Not sure about it though, since when using this option any errors will be ignored, even when pdf is not generated. More correct way is to check if we got any output and if there are errors - we can ignore those, and if output is missing - properly raise an exception |
Hey, |
Hi, again:) |
Looks like GH CI is broken atm... No time to review at the moment, sorry. I'll try to test it on this weekend |
Thank you, this errors looks vary unusual. |
Hi all, I've been working with pdfkit and found several cases where wkhtmltopdf outputs errors, but still generates a pdf. I would like to be able to manually control how the pdf-kit responds to errors.
ps: I apologize if I violate protocol in any way, this is my first time doing pull request to opensource.