Error handling fixes #170
Merged
Error handling fixes #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue #158.
This addresses issue #164.
Turns out the hang was actually open() blocking until the jana status FIFO had a reader. It doesn't make sense for the segfault handler to even write to the FIFO; the log is sufficient. This addresses issue #158.
JProcessorMapping no longer calls out to `lscpu` unless the user specifically enables NUMA awareness by setting jana:affinity or jana:locality parameters. This means the massive table of thread assignments disappears from the log until it is actually necessary, and users see one fewer perplexing error message the rest of the time.
Now behaves correctly running in eic-shell on a mbp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of bugs that have surfaced, and cleans up the log output so as not to confuse users.
lscpuchild process, to avoid leaving a zombie (run_eicrecon and eicrecon do not handle SIGINT well (leave zombie in case of run_eicrecon) eic/EICrecon#310)lscpuchild process by default, unless the user wants NUMA awareness