Improve handling of multiple JEventSources #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, multiple event sources would each be assigned separate JEventSourceArrows and be run at the same time. This PR changes JEventProcessorArrow so that it accepts a vector of JEventSources and runs them one after another until each completes or reaches the max
jana:nevents'. This leads to fewer files/sockets being open simultaneously, better performance due to fewer calls to
JFactory::ChangeRun` etc, less work for the scheduler, and a more easy-to-reason-about event stream. The old behavior is easy to bring back in the JTopologyBuilder if we ever want it.This addresses issue #146.
It includes some refactorings:
There is one small behavior modification: