Feature: Add support for std::array parameters (Addresses issue #236) #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s://github.com/JeffersonLab/JANA2 into AyanRoy16-issue-236-Adding-array-in-Jparameter
AyanRoy16
changed the title
nathanwbrei
reviewed
Oct 2, 2023
| inline void JParameterManager::Parse(const std::string& value, bool& val) { | ||
| if (value == "0" || value =="false" || value == "off") val = false; | ||
| else if (value == "1" || value == "true" || value == "on") val = true; | ||
| else throw JException("'%s' not parseable as bool", value.c_str()); | ||
| } |
There was a problem hiding this comment.
It's probably fine here, but in general I'd advise against rearranging ugly logic unless it is truly necessary, particularly when parsing is involved. It's just so easy to introduce bugs or activate bugs that have been lying dormant. Particularly when our test cases are this light.
nathanwbrei
changed the title
nathanwbrei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding array as a return type at JParameter.h .
[X] Passing existing test cases
[X] New test cases added