Improve exception handling logic in all components #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nathanwbrei
commented
May 3, 2024
•
nathanwbrei
commented
- JException now reports wrapped exception type
- Created JException wrapper common to all components (except JFactory, for now)
- Renamed fields on JException to make sense for all components
This will substantially clean up our component internals, while making exception handling more consistent and reliable
Putting the callback name in the exception message was making the messages very long and obscuring the important part
Now uses (function_name, type_name, instance_name, plugin_name) which make sense for all components
nathanwbrei
changed the title
Addresses issue #277.
nathanwbrei
force-pushed
the
nbrei_improve_exceptions
branch
from
75b23bc
to
f2f340b
Compare
nathanwbrei
changed the title
nathanwbrei
force-pushed
the
nbrei_improve_exceptions
branch
from
3fd909f
to
107d202
Compare
Previously, it was the JEventSource, which doesn't work in the case of TimesliceExample, because PhysicsEvents come straight from the pool.
nathanwbrei
force-pushed
the
nbrei_improve_exceptions
branch
from
107d202
to
8a74887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.