fix: do not force transient qa-physics files to be in qa-physics/ source directory
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dilks
force-pushed
the
free-physics-outfiles
branch
from
c866c67 to
0a47f42
Compare
c-dilks
force-pushed
the
free-physics-outfiles
branch
2 times, most recently
from
8b39192 to
29248db
Compare
c-dilks
force-pushed
the
free-physics-outfiles
branch
from
29248db to
392aed4
Compare
|
The auto QA has been tested on RGB data in preparation for a Pass 2 review. It's possible the manual QA is a bit broken from this PR, but likely it's straightforward to fix. Since the next manual QA awaits progress on #111, let's wait until then to fix any of those issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transient files
qa-physics/out{dat,mon}.$datasetfiles are used by practically all scripts inqa-physics, another issue similar to #115. This PR continues the idea of #122, allowing for flexibility of the placement of these transient files.$TIMELINESRC,outdat, andoutmon