Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass user args to mvn in build-coatjava.sh #172

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Jan 19, 2024

This allows user arguments to be passed to the mvn command used in build-coatjava.sh.

I originally did this so one can run mvn multi-threaded, e.g.,

build-coatjava.sh -T 4  # runs with 4 threads

however, coatjava builds so quickly that this does not make any improvement whatsoever.

Maybe this PR will be useful someday though...

time build-coatjava.sh       # 70.39s user 3.69s system 335% cpu 22.071 total
time build-coatjava.sh       # 68.33s user 3.32s system 386% cpu 18.538 total

time build-coatjava.sh -T 1  # 64.44s user 3.39s system 339% cpu 19.979 total
time build-coatjava.sh -T 1  # 73.75s user 3.68s system 356% cpu 21.702 total

time build-coatjava.sh -T 2  # 76.67s user 3.77s system 501% cpu 16.045 total
time build-coatjava.sh -T 2  # 75.24s user 3.69s system 431% cpu 18.291 total

time build-coatjava.sh -T 4  # 74.28s user 4.00s system 486% cpu 16.075 total
time build-coatjava.sh -T 4  # 73.92s user 4.01s system 546% cpu 14.262 total

time build-coatjava.sh -T 8  # 68.79s user 3.97s system 517% cpu 14.059 total
time build-coatjava.sh -T 8  # 75.55s user 4.11s system 461% cpu 17.256 total

@baltzell baltzell merged commit 750a0bb into development Jan 23, 2024
67 checks passed
@baltzell baltzell deleted the mvn-args branch January 23, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants