chore: add py.typed #398
Closed
chore: add py.typed #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtmckee
suggested changes
Feb 1, 2025
There was a problem hiding this comment.
-
There isn't currently a
py.typedfile in the source tree. Did you test that the project can be built after adding this change? -
mypy isn't being run against the project in CI to confirm that the type annotations are coherent. Adding a
py.typedfile to claim that the project is typed isn't much of a claim without actually testing the type annotations.
I recommend modifying CI to run mypy against the project to confirm that the type annotations are coherent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #397, adding a py.typed to the package.