Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: EXPOSED-642 Support both DSL and DAO transform #2309

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

obabichevjb
Copy link
Collaborator

Description

With this PR the DAO transform API will be undeprecated. Both DAO and DSL transform will exist.


Affected databases:

  • All

Related Issues

EXPOSED-642 Support both DSL and DAO transform

@obabichevjb obabichevjb requested a review from bog-walk November 15, 2024 10:39
Copy link
Member

@bog-walk bog-walk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend waiting until after PR #2302 is merged to rebase and resolve conflicts since the entire 'DAO-Field-Transformations.topic' is being moved.
Otherwise, if you want to merge first, please consider syncing with @vnikolova after to rebase that PR before it is merged.

@obabichevjb obabichevjb force-pushed the obabichev/exposed-642-restore-dao-transform branch from 20b874a to 0ea4859 Compare November 18, 2024 08:39
@obabichevjb
Copy link
Collaborator Author

@vnikolova I updated some documentation about Transform API here, I also found that kotlin examples were moved into kotlin files, so I did it for new example also.

Copy link
Collaborator

@vnikolova vnikolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding the example. Just a couple minor suggestions in the comments.

@obabichevjb obabichevjb merged commit fc0ae76 into main Nov 25, 2024
5 checks passed
@obabichevjb obabichevjb deleted the obabichev/exposed-642-restore-dao-transform branch November 29, 2024 09:32
mnonnenmacher added a commit to eclipse-apoapsis/ort-server that referenced this pull request Dec 6, 2024
The deprecation of the DAO transform API was reverted in Exposed 0.57.0,
see [1] and [2].

[1]: https://github.com/JetBrains/Exposed/blob/main/CHANGELOG.md#0570
[2]: JetBrains/Exposed#2309

Signed-off-by: Martin Nonnenmacher <[email protected]>
github-merge-queue bot pushed a commit to eclipse-apoapsis/ort-server that referenced this pull request Dec 6, 2024
The deprecation of the DAO transform API was reverted in Exposed 0.57.0,
see [1] and [2].

[1]: https://github.com/JetBrains/Exposed/blob/main/CHANGELOG.md#0570
[2]: JetBrains/Exposed#2309

Signed-off-by: Martin Nonnenmacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants