Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EXPOSED-653 Split H2 gradle test task by dialects #2317

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

obabichevjb
Copy link
Collaborator

Description

Here is a small fix of our gradle test tasks. Before it was not possible to run the tests for particular H2 dialect (or the one without dialect). It was not always convenient for local testing and especially debugging.

With these changes for every database that has multiple dialects (H2_v1, H2_v2 actually) would be created separated gradle task with the name test_${db}_${dialect}. The task that would run tests with all the dialects (as it was working before) would be named test_all_${db}.

The full list of test tasks will look like:

test
test_all_h2_v1
test_all_h2_v2
test_h2_v1
test_h2_v1_mysql
test_h2_v2
test_h2_v2_mariadb
test_h2_v2_mysql
test_h2_v2_oracle
test_h2_v2_psql
test_h2_v2_sqlserver
test_mariadb_v2
test_mariadb_v3
test_mysql_v5
test_mysql_v8
test_oracle
test_postgres
test_postgresng
test_sqlite
test_sqlserver

I also renamed mysql databases so it matches other database names.


Type of Change

Please mark the relevant options with an "X":

  • Bug fix

Affected databases:

  • H2
  • MySql

Related Issues

EXPOSED-653 Split H2 gradle test task by dialects

@obabichevjb obabichevjb force-pushed the obabichev/exposed-653-split-test-gradle-tasks branch from f07e4f8 to b0bee7f Compare November 25, 2024 13:49
build.gradle.kts Show resolved Hide resolved
@obabichevjb obabichevjb requested review from bog-walk and e5l November 26, 2024 11:31
Copy link
Member

@bog-walk bog-walk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build test count is still lower than on main but that may just be because of how grouped tests are counted by TC, as they are now (correctly) all being run separately for each H2 mode. Meaning both tasks test_all_h2_v1 and test_all_h2_v2 don't run any tests & delegate to the separate modes, which I think makes sense.

@obabichevjb obabichevjb merged commit eb8d09d into main Nov 27, 2024
5 checks passed
@obabichevjb obabichevjb deleted the obabichev/exposed-653-split-test-gradle-tasks branch November 27, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants