EXPOSED-689 warmUpLinkedReferences() should not return all the values from cache #2355
+58
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Provide a concise summary of this PR. Describe the changes made in a single sentence or short paragraph.
Detailed description:
EntityClass::warmUpLinkedReferences()was filling the cache by values fromreferencesargument and returning after that all the values from cache. As a result on the second call with a new list ofreferencesthe wrong result was returned (all the values from the cache were returned)referencesargument and return the filtered result.Type of Change
Affected databases:
Related Issues
EXPOSED-689 warmUpLinkedReferences() should not return all the values from cache