fix: EXPOSED-680 Less & greater infix ops cannot compile with 2 EntityID expressions #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yID expressions - When EntityID was no longer made comparable, some operators that relied on this implementation were not adjusted immediately, namely less, lessEq, greater, and greaterEq. - It has been requested that they allow both left and right side operators to be of type Expression<EntityID>. - Add the necessary overloads & adjust tests.
…yID expressions - Add api dump
bog-walk
force-pushed
the
bog-walk/add-comparable-entity-infix-ops
branch
from
71dfed0 to
7831105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Add overloads for infix operators that allow comparison between left- and right-side
Expression<EntityID<?>>.Detailed description:
After PR #2277 removed the
Comparablerestriction fromEntityID, the use of an entity'sidwith certain Exposed functions that originally maintained this restriction required defining a new function (as mentioned in the final point of 0.56.0 breaking changes).These operators currently only support
Expression<EntityID<?>>as either the left- OR right-side operand for comparison against a literal value or an expression that holds a literal value.It has now been requested that the signature of some comparison infix operators be reassessed to allow usage like
Table1.id less Table2.idand similar usage ofEntityIDexpressions on both sides of the operator.less(),lessEq(),greater(), andgreaterEq().Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-680