fix: EXPOSED-707 Handle MariaDB fractional seconds support since version 5.3 #2378
+13
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
isVersionCovers
function to handle comparison of 8.0 with 5.6.MariaDBDialect
class extendable to be consistent with other dialect classes.According to the documentation here, MariaDB introduced fractional seconds support in temporal data types from version 5.3. For MySQL, it's from version 5.6. Previously, Exposed was assuming it was 5.6 for both MariaDB and MySQL.
Modified
isFractionDateTimeSupported
inMysqlDialect
to be open and overrided it inMariaDBDialect
to return the correct result for MariaDB 5.3 onwards.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues