Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EXPOSED-707 Handle MariaDB fractional seconds support since version 5.3 #2378

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joc-a
Copy link
Collaborator

@joc-a joc-a commented Jan 28, 2025

Detailed description:

  • What:
  1. Handle MariaDB fractional seconds support since version 5.3.
  2. Fixed mistake in KDocs referring to JDBC connector version instead of database version.
  3. Fixed isVersionCovers function to handle comparison of 8.0 with 5.6.
  4. Made the MariaDBDialect class extendable to be consistent with other dialect classes.
  • Why:
    According to the documentation here, MariaDB introduced fractional seconds support in temporal data types from version 5.3. For MySQL, it's from version 5.6. Previously, Exposed was assuming it was 5.6 for both MariaDB and MySQL.
  • How:
    Modified isFractionDateTimeSupported in MysqlDialect to be open and overrided it in MariaDBDialect to return the correct result for MariaDB 5.3 onwards.

Type of Change

Please mark the relevant options with an "X":

  • Bug fix
  • New feature
  • Documentation update

Updates/remove existing public API methods:

  • Is breaking change

Affected databases:

  • MariaDB
  • Mysql5
  • Mysql8
  • Oracle
  • Postgres
  • SqlServer
  • H2
  • SQLite

Checklist

  • Unit tests are in place
  • The build is green (including the Detekt check)
  • All public methods affected by my PR has up to date API docs
  • Documentation for my change is up to date

Related Issues

@joc-a joc-a marked this pull request as ready for review January 28, 2025 19:12
@joc-a joc-a requested a review from obabichevjb January 28, 2025 19:13
@joc-a joc-a force-pushed the joc/exposed-707 branch 3 times, most recently from 5945608 to 85d15dd Compare January 29, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant