refactor: EXPOSED-708 Remove JDBC DatabaseMetaData from exposed-core module #2379
+42
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DatabaseDialect has a method resolveRefOptionFromJdbc that finds a ReferenceOption match for a jdbc-specific enum constant. - This removes such logic from the core module and leaves it in the jdbc module. - The new method is labeled as internal as it will need an r2dbc-specific override.
…module - Undo MySQL change until custom sql extracted from dialect too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
exposed-coreno longer uses JDBCDatabaseMetaDatato resolve metadata query results intoReferenceOptionconstants.Detailed description:
In preparation for R2DBC, all JDBC specific metadata processing must be extracted from the core module.
DatabaseDialect.resolveRefOptionFromJdbc()currently relies on JDBCDatabaseMetaDatato find a matchingReferenceOptionwhen table constraints are being generated by metadata query results.ExposedDatabaseMetadata.resolveReferenceOption()(so that it can be implemented for JDBC now and R2DBC later)DatabaseDialect.resolveRefOptionFromJdbc()and have it call the above.exposed-jdbcType of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-708
R2DBC parent - EXPOSED-517