refactor: EXPOSED-709 Remove plain SQL execution from core DatabaseDialect #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alect In preparation fro R2DBC, the following instances of JDBC transaction-specific execution have been removed from the core module: - Retrieving H2 mode - Retrieving all sequences in the database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
vendorspackage no longer has any metadata retrieved viaTransaction.exec(). PR #2380 is open in conjunction to this one, since the extraction required a bit more.Detailed description:
In preparation for R2DBC, instances of JDBC transaction-specific execution need to be removed from
exposed-coreand this focuses on the metadata retrieval queries invendors, namely:- H2 mode retrieval
- Query for all sequences in db
ExposedDatabaseMetadatat.databaseDialectModeproperty that can be called byH2Dialect.h2Modeand extract its logic toexposed-jdbc.isDotPrefixedAndUnquoted()for identifier manager to be used when processing sequence results. Both this method and the 1 above are introduced as they will both need to be used by the new R2DBC module.sequences().Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-709
R2DBC parent - EXPOSED-517