Move Proguard version from ProguardSettings.kt To Gradle version catalog #4946
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is specific to Compose Desktop, when using Compose Desktop Gradle plugin to build the release version of the application
Move the Proguard version from
ProguardSettings.kt
togradle/libs.versions.toml
without any breaking change, this PR shouldn't affect the functionality, tests, or anything in any wayTesting
Describe how you tested your changes. If possible and needed:
gradlew build -x test
didn't skip the tests, in general, this PR should not introduce any new bugs, the propertyDEFAULT_PROGUARD_VERSION
was is private inProguardSettings.kt
ComposeBuildConfigTest
or anything that tests the generated file,DEFAULT_PROGUARD_VERSION
, or anything that's related to adding new tests.gradle.properties
others are ingradle/libs.versions.toml
, I wasn't certain when should I use the Gradel version catalog orgradle.properties
in this projectLet me know if any additional changes are required or if I should move the Proguard version to
gradle.properties
, rename thedefault-proguard