Fix skiko.js unpacking for k/js target #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K/JS and K/Wasm have differences in the packaging logic, and therefore we need to account for it when unpacking Skiko files. Fixes CMP-5649
Schahen
reviewed
Jul 22, 2024
| if (it.name.contains("wasmJs", ignoreCase = true)) { | ||
| it.dependsOn(unpackRuntime) | ||
| it.from.from(unpackedRuntimeDir) | ||
| } |
There was a problem hiding this comment.
Can we leave small explanation on why we are actually doing this?
The other question - any chance those "wasmJs" tasks have some narrower type we can rely on rather then IncrementalSyncTask
There was a problem hiding this comment.
refactored and added the comments. Thanks to @ilgonmic for help with KGP and explanation
Schahen
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K/JS and K/Wasm have differences in the packaging logic, and therefore we need to account for it when unpacking Skiko files.
Fixes CMP-5649
Testing
This should be tested by QA