serial-monitor: Support LF line-ending mode and fix split-up line-endings #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds LF ("\n") line ending support, completing coverage for all line endings ("\r", "\n", "\r\n").
It also provides a robust solution for line endings split across chunks (the issue from the todo comment that points to https://bitbucket.org/dmitry_cherkas/intellij-serial-monitor/issues/1), replacing the previous temporary fix. Since the bitbucket repo is offline I had to use ribasco/intellij-serial-monitor@1414af0 to find the linked issue.
|
Would it help to have a bug tracker entry about the bug that this PR fixed? Would be nice to have this fix implemented for me and some other folks that have to use additional programs currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was working with a serial interface platform that uses LF-only line endings so the received data would output to a single line. This addresses that, alongside an existing issue with how it deals with line-endings that are split between chunks.
What this fixes