Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart] Add 'Sort Members in Dart Code' to project view action menu #927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parlough
Copy link
Contributor

@parlough parlough commented Oct 9, 2024

Working on Dart projects that rely on member sorting, this enables much quicker access to the sort member functionality from the project view's action menu.

This PR also adjusts the text to "Sort Members in Dart code" rather than files as it can show up when selecting one or many files. It also aligns better with the the formatting action's text.

\cc @jwren

@alexander-doroshko alexander-doroshko self-assigned this Oct 9, 2024
@jwren
Copy link
Contributor

jwren commented Oct 9, 2024

LGTM, thank you for the contributions @parlough

@alexander-doroshko
Copy link
Member

alexander-doroshko commented Oct 15, 2024

I'll take a pause to think how natural the Sort Members action feels in the already overloaded Project View context menu...

By the way, it's probably a good time to remove Reformat Code with 'dart format' action from all action groups. It's currently in 3. These 3 groups already contain Reformat Code, which is effectively the same as Reformat Code with 'dart format'. Would you agree?

By the way, you can configure actions in the Project View context menu (and in all other menus and toolbars). Just add Sort Members there in Settings | Appearance & Behavior | Menus and Toolbars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants