php-ds: add missed return types for the getIterator() methods #1607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image that you have a method which returns a generic collection:
And also you have another method where you iterate over that collection:
If both methods are in the same class, everything works good. But if these classes are in different classes, phpstorm will no understand a time of collection's item inside foreach.
Everything works properly for the Queue collection, but there is problems with other collections. I see that there is a phpdoc for the Queue::getIterator() method:
but there is no such ones for other collection.
So this MR fixes this issue