-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs(commitlint): add guidelines for contributing
- Loading branch information
1 parent
9448c63
commit d055276
Showing
2 changed files
with
92 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
|
||
# Contributing | ||
|
||
We would love for you to contribute to WebView Angular Electron and help make it even better than it is | ||
today! As a contributor, here are the guidelines we would like you to follow: | ||
|
||
- [Commit Message Guidelines](#commit) | ||
|
||
|
||
## <a name="commit"></a> Commit Message Guidelines | ||
|
||
We have very precise rules over how our git commit messages can be formatted. This leads to **more | ||
readable messages** that are easy to follow when looking through the **project history**. But also, | ||
we use the git commit messages to **generate the changelog**. | ||
|
||
### Commit Message Format | ||
Each commit message consists of a **header**, a **body** and a **footer**. The header has a special | ||
format that includes a **type**, a **scope** and a **subject**: | ||
|
||
``` | ||
<type>(<scope>): <subject> | ||
<BLANK LINE> | ||
<body> | ||
<BLANK LINE> | ||
<footer> | ||
``` | ||
|
||
The **header** is mandatory and the **scope** of the header is optional. | ||
|
||
Any line of the commit message cannot be longer 100 characters! This allows the message to be easier | ||
to read on GitHub as well as in various git tools. | ||
|
||
``` | ||
docs(changelog): update changelog to beta.5 | ||
``` | ||
``` | ||
fix(release): need to depend on latest rxjs and zone.js | ||
The version in our package.json gets copied to the one we publish, and users need the latest of these. | ||
``` | ||
|
||
### Revert | ||
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted. | ||
|
||
### Type | ||
Must be one of the following: | ||
|
||
* **feat**: A new feature | ||
* **fix**: A bug fix | ||
* **docs**: Documentation only changes | ||
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) | ||
* **refactor**: A code change that neither fixes a bug nor adds a feature | ||
* **perf**: A code change that improves performance | ||
* **test**: Adding missing tests or correcting existing tests | ||
* **chore**: Changes to the build process or auxiliary tools and libraries such as documentation generation | ||
* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) | ||
* **ci**: Changes to our CI configuration files and scripts (example scopes: Circle, BrowserStack, SauceLabs) | ||
|
||
### Scope | ||
The scope should be the name of the npm package affected (as perceived by the person reading the changelog generated from commit messages. | ||
|
||
There are currently a few exceptions to the "use package name" rule: | ||
|
||
* **packaging**: used for changes that change the npm package layout in all of our packages, e.g. | ||
public path changes, package.json changes done to all packages, d.ts file/format changes, changes | ||
to bundles, etc. | ||
* **changelog**: used for updating the release notes in CHANGELOG.md | ||
* none/empty string: useful for `style`, `test` and `refactor` changes that are done across all | ||
packages (e.g. `style: add missing semicolons`) and for docs changes that are not related to a | ||
specific package (e.g. `docs: fix typo in tutorial`). | ||
|
||
### Subject | ||
The subject contains a succinct description of the change: | ||
|
||
* use the imperative, present tense: "change" not "changed" nor "changes" | ||
* don't capitalize the first letter | ||
* no dot (.) at the end | ||
|
||
### Body | ||
Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes". | ||
The body should include the motivation for the change and contrast this with previous behavior. | ||
|
||
### Footer | ||
The footer should contain any information about **Breaking Changes** and is also the place to | ||
reference GitHub issues that this commit **Closes**. | ||
|
||
**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters