fix(autoware_accel_brake_map_calibrator): fix redundantInitialization (…

…autowarefoundation#8230) Signed-off-by: Ryuta Kambe <[email protected]>
JianKangEgon · Aug 6, 2024 · ea8ff9d · ea8ff9d
1 parent ca32505
commit ea8ff9d
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/vehicle/autoware_accel_brake_map_calibrator/src/accel_brake_map_calibrator_node.cpp b/vehicle/autoware_accel_brake_map_calibrator/src/accel_brake_map_calibrator_node.cpp
@@ -1326,15 +1326,12 @@ void AccelBrakeMapCalibrator::check_update_suggest(
   using DiagStatus = diagnostic_msgs::msg::DiagnosticStatus;
   using CalibrationStatus = CalibrationStatus;
   CalibrationStatus accel_brake_map_status;
+  accel_brake_map_status.target = CalibrationStatus::ACCEL_BRAKE_MAP;
+  accel_brake_map_status.status = CalibrationStatus::NORMAL;
   int8_t level = DiagStatus::OK;
-  std::string msg;
+  std::string msg = "OK";
 
-  accel_brake_map_status.target = CalibrationStatus::ACCEL_BRAKE_MAP;
-  if (is_default_map_) {
-    accel_brake_map_status.status = CalibrationStatus::NORMAL;
-    level = DiagStatus::OK;
-    msg = "OK";
-  } else {
+  if (!is_default_map_) {
     accel_brake_map_status.status = CalibrationStatus::UNAVAILABLE;
     level = DiagStatus::ERROR;
     msg = "Default map is not found in " + csv_default_map_dir_;