Add Predis support #55
Conversation
fesor
force-pushed
the
predis_support
branch
from
6e4b88a to
4b675e3
Compare
|
@schnipseljagd @bracki guys, what do you think on this? |
|
I'd prefer to refactor the class so that it takes either a Redis or a Predis |
|
Will try to do that. |
fesor
force-pushed
the
predis_support
branch
from
4b675e3 to
5f5113a
Compare
- Encapsulate differences between predis and redis behind single abstraction. - Reduce duplication in tests
|
@bracki so, I need this again so I finally managed to work on this PR. I added additional abstraction which hides difference between redis and predis without sacrifice lazy connection in case of redis. I really not sure it is ok or not. |
| @@ -49,9 +49,9 @@ public function pushAdd(CollectorRegistry $collectorRegistry, $job, $groupingKey | |||
| * @param $job | |||
| * @param $groupingKey | |||
| */ | |||
| public function delete($job, $groupingKey = null) | |||
| public function delete(CollectorRegistry $collectorRegistry, $job, $groupingKey = null) | |||
There was a problem hiding this comment.
$collectorRegistry is left out on purpose here. It's not being used anyways. Modeled after the Python implementation which also leaves out the registry when doing a delete.
|
What is status of this pr? |
|
Is there anything I could help with this PR to get merged? This would be a really nice feature :( |
|
This project is dead, but I'm maintaining it under my employer - https://github.com/endclothing/prometheus_client_php. Feel free to submit the PR there. |
For #52