Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed navbar in mobile #168

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Fixed navbar in mobile #168

merged 3 commits into from
Oct 24, 2024

Conversation

PAVAN507-STAR
Copy link
Contributor

Fixed the navabr overlapping issue in mobile by adding a toggle menu button to the right edge of the screen.Added different blurred backgrounds for black and white theme.Made sure the look on pc remained same.Closes issue #161.
image
image
image

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hacktoberwall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 7:04pm

Phanty78
Phanty78 requested changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Phanty78 Phanty78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good.
Please don't erase all commentary in CSS file.

@PAVAN507-STAR
Copy link
Contributor Author

Code seems good. Please don't erase all commentary in CSS file.
Yeah sure . @Phanty78 show i raise another pr.I'm new to git and open source so correct if im wrong

@JollyJolli
Copy link
Owner

It's just like I wanted! Thank you! But please solve the changes that Phanty78 asked for.

@JollyJolli
Copy link
Owner

Code seems good. Please don't erase all commentary in CSS file.

Yeah sure . @Phanty78 show i raise another pr.I'm new to git and open source so correct if im wrong

Just make a commit and it will apper here

@PAVAN507-STAR
Copy link
Contributor Author

PAVAN507-STAR commented Oct 24, 2024 •
edited
Loading

Hii @Phanty78 @JollyJolli .Restored the comments in css file as u said.Btw sorry for the delay had some college stuff to do(exams).Please let me if there's anything else to change

Phanty78
Phanty78 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@Phanty78 Phanty78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, I approve it.

@Phanty78
Copy link
Collaborator

Just fix the conflict and push the corrected code and i will merge it. @PAVAN507-STAR

@Phanty78
Copy link
Collaborator

Oh : and don't forgot to minify the CSS please ;)

@PAVAN507-STAR
Copy link
Contributor Author

Hii @Phanty78 .Done solved the conflicts

@JollyJolli JollyJolli linked an issue Oct 24, 2024 that may be closed by this pull request
Fix Responsiveness for Navigation Bar on Mobile Devices #161
Closed
6 tasks
@JollyJolli
Copy link
Owner

I look it good but i will wait for Phanty's response cuz this is his issue

Phanty78
Phanty78 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@Phanty78 Phanty78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, let's go !

@Phanty78 Phanty78 merged commit 4adf6ae into JollyJolli:main Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phanty78 Phanty78 Phanty78 approved these changes

@JollyJolli JollyJolli Awaiting requested review from JollyJolli JollyJolli is a code owner

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest2024 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Responsiveness for Navigation Bar on Mobile Devices
3 participants
@PAVAN507-STAR @JollyJolli @Phanty78