Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #194

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

martincostello
Copy link
Contributor

I came across this project via a Google search, but it brought me to the repository not the NuGet package. There was no explicit link to the package anywhere in the README, so I had to manually go off and find it. These changes to the README should hopefully make it easier for people to get started in the future.

The included changes also:

  • Add NuGet badges.
  • Add namespace to first code snippet.
  • Change dotnet to .NET.
  • Change nuget to NuGet.
  • Fix Visual Studio Code MarkdownLint warnings.

I haven't run the code to regenerate the documentation files from their source as:

  1. I don't have make installed
  2. The scripts are written in bash and I have a Windows computer

- Add NuGet badges.
- Add links to the NuGet packages.
- Add namespace to first code snippet.
- Change `dotnet` to `.NET`.
- Change `nuget` to `NuGet`.
- Fix Visual Studio Code MarkdownLint warnings.
@JoshKeegan
Copy link
Owner

Hi @martincostello,
Thanks for taking the time to improve the docs. I'll run the generation again 👍 If you do ever want to contribute to the project again & need to run the build scripts, both make & bash can be installed on windows & work quite well. I've run these on windows myself previously using the version of bash that comes bundled with git, so they should still all work on windows.

I'll also split your changes to the CI badge file as that gets included in the .md that is published with each nuget package.

@JoshKeegan JoshKeegan merged commit 15129b8 into JoshKeegan:master Sep 5, 2023
2 of 3 checks passed
@martincostello martincostello deleted the link-to-nuget branch September 6, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants