Skip to content

Commit

Permalink
fix: include .git in repository.url
Browse files Browse the repository at this point in the history
@JoshuaKGoldberg
JoshuaKGoldberg committed Jan 3, 2025
1 parent 777d413 commit 98c1226
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
"description": "Quickstart-friendly TypeScript template with comprehensive, configurable, opinionated tooling. ❤️‍🔥",
"repository": {
"type": "git",
"url": "https://github.com/JoshuaKGoldberg/create-typescript-app"
"url": "git+https://github.com/JoshuaKGoldberg/create-typescript-app.git"
},
"license": "MIT",
"author": {
8 changes: 4 additions & 4 deletions src/next/blocks/blockPackageJson.test.ts
View file
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ describe("blockPackageJson", () => {
expect(creation).toMatchInlineSnapshot(`

Check failure on line 13 in src/next/blocks/blockPackageJson.test.ts

GitHub Actions / Test

src/next/blocks/blockPackageJson.test.ts > blockPackageJson > without addons or mode 

Error: Snapshot `blockPackageJson > without addons or mode 1` mismatched

- Expected
+ Received

@@ -1,8 +1,8 @@
  {
    "files": {
-     "package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"]}",
+     "package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"git+https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"]}",
    },
    "scripts": [
      {
        "commands": [
          "pnpm install",

 ❯ src/next/blocks/blockPackageJson.test.ts:13:20
{
"files": {
"package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"]}",
"package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"]}",
},
"scripts": [
{
@@ -36,7 +36,7 @@ describe("blockPackageJson", () => {
expect(creation).toMatchInlineSnapshot(`

Check failure on line 36 in src/next/blocks/blockPackageJson.test.ts

GitHub Actions / Test

src/next/blocks/blockPackageJson.test.ts > blockPackageJson > migration mode 

Error: Snapshot `blockPackageJson > migration mode 1` mismatched

- Expected
+ Received

@@ -1,8 +1,8 @@
  {
    "files": {
-     "package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"]}",
+     "package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"git+https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"]}",
    },
    "scripts": [
      {
        "commands": [
          "pnpm install",

 ❯ src/next/blocks/blockPackageJson.test.ts:36:20
{
"files": {
"package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"]}",
"package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"]}",
},
"scripts": [
{
@@ -73,7 +73,7 @@ describe("blockPackageJson", () => {
expect(creation).toMatchInlineSnapshot(`

Check failure on line 73 in src/next/blocks/blockPackageJson.test.ts

GitHub Actions / Test

src/next/blocks/blockPackageJson.test.ts > blockPackageJson > with addons 

Error: Snapshot `blockPackageJson > with addons 1` mismatched

- Expected
+ Received

@@ -1,8 +1,8 @@
  {
    "files": {
-     "package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"],"dependencies":{"is-odd":"1.2.3"},"other":true}",
+     "package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"git+https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"],"dependencies":{"is-odd":"1.2.3"},"other":true}",
    },
    "scripts": [
      {
        "commands": [
          "pnpm install",

 ❯ src/next/blocks/blockPackageJson.test.ts:73:20
{
"files": {
"package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"],"dependencies":{"is-odd":"1.2.3"},"other":true}",
"package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"],"dependencies":{"is-odd":"1.2.3"},"other":true}",
},
"scripts": [
{
@@ -108,7 +108,7 @@ describe("blockPackageJson", () => {
expect(creation).toMatchInlineSnapshot(`

Check failure on line 108 in src/next/blocks/blockPackageJson.test.ts

GitHub Actions / Test

src/next/blocks/blockPackageJson.test.ts > blockPackageJson > with addons adding devDependencies 

Error: Snapshot `blockPackageJson > with addons adding devDependencies 1` mismatched

- Expected
+ Received

@@ -1,8 +1,8 @@
  {
    "files": {
-     "package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"],"dependencies":{"is-odd":"1.2.3"},"devDependencies":{"is-even":"4.5.6"},"other":true}",
+     "package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"git+https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"],"dependencies":{"is-odd":"1.2.3"},"devDependencies":{"is-even":"4.5.6"},"other":true}",
    },
    "scripts": [
      {
        "commands": [
          "pnpm install",

 ❯ src/next/blocks/blockPackageJson.test.ts:108:20
{
"files": {
"package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"],"dependencies":{"is-odd":"1.2.3"},"devDependencies":{"is-even":"4.5.6"},"other":true}",
"package.json": "{"name":"test-repository","version":"0.0.0","description":"Test description","repository":{"type":"git","url":"https://github.com/test-owner/test-repository.git"},"license":"MIT","author":{"email":"npm@email.com"},"type":"module","main":"./lib/index.js","files":["README.md","package.json"],"dependencies":{"is-odd":"1.2.3"},"devDependencies":{"is-even":"4.5.6"},"other":true}",
},
"scripts": [
{
2 changes: 1 addition & 1 deletion src/next/blocks/blockPackageJson.ts
View file
Original file line number Diff line number Diff line change
@@ -83,7 +83,7 @@ export const blockPackageJson = base.createBlock({
name: options.repository,
repository: {
type: "git",
url: `https://github.com/${options.owner}/${options.repository}`,
url: `git+https://github.com/${options.owner}/${options.repository}.git`,
},
scripts: {
...options.packageData?.scripts,
4 changes: 2 additions & 2 deletions src/steps/writing/creation/writePackageJson.test.ts
View file
Original file line number Diff line number Diff line change
@@ -96,7 +96,7 @@ describe("writePackageJson", () => {
},
"repository": {
"type": "git",
"url": "https://github.com/test-owner/test-repository",
"url": "https://github.com/test-owner/test-repository.git",
},
"scripts": {
"build": "tsup",
@@ -168,7 +168,7 @@ describe("writePackageJson", () => {
},
"repository": {
"type": "git",
"url": "https://github.com/test-owner/test-repository",
"url": "https://github.com/test-owner/test-repository.git",
},
"scripts": {
"format": "prettier .",
2 changes: 1 addition & 1 deletion src/steps/writing/creation/writePackageJson.ts
View file
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ export async function writePackageJson(options: Options) {
},
repository: {
type: "git",
url: `https://github.com/${options.owner}/${options.repository}`,
url: `git+https://github.com/${options.owner}/${options.repository}.git`,
},
scripts: {
...existingPackageJson.scripts,

0 comments on commit 98c1226

Please sign in to comment.