Skip to content

Commit

Permalink
chore: cleanup --report-unused-disable-directives (#1093)
Browse files Browse the repository at this point in the history
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #1089 
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes all references to `--report-unused-disable-directives`
  • Loading branch information
jaas666 authored Dec 12, 2023
1 parent 2368600 commit a415ced
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/steps/writing/creation/writePackageJson.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ describe("writePackageJson", () => {
"scripts": {
"build": "tsup",
"format": "prettier "**/*" --ignore-unknown",
"lint": "eslint . .*js --max-warnings 0 --report-unused-disable-directives",
"lint": "eslint . .*js --max-warnings 0",
"lint:knip": "knip",
"lint:md": "markdownlint "**/*.md" ".github/**/*.md" --rules sentences-per-line",
"lint:package-json": "npmPkgJsonLint .",
Expand Down Expand Up @@ -172,7 +172,7 @@ describe("writePackageJson", () => {
"scripts": {
"build": "tsup",
"format": "prettier "**/*" --ignore-unknown",
"lint": "eslint . .*js --max-warnings 0 --report-unused-disable-directives",
"lint": "eslint . .*js --max-warnings 0",
"prepare": "husky install",
"tsc": "tsc",
},
Expand Down
2 changes: 1 addition & 1 deletion src/steps/writing/creation/writePackageJson.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export async function writePackageJson(options: Options) {
scripts: {
build: "tsup",
format: 'prettier "**/*" --ignore-unknown',
lint: "eslint . .*js --max-warnings 0 --report-unused-disable-directives",
lint: "eslint . .*js --max-warnings 0",
...(!options.excludeLintKnip && {
"lint:knip": "knip",
}),
Expand Down

0 comments on commit a415ced

Please sign in to comment.