Skip to content

Commit

Permalink
fix: finish removing **/*.md/*.ts eslint.config.js overrides (#1699)
Browse files Browse the repository at this point in the history
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #1690 (continues, really)
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

I'd left in this bit by accident.

💖
  • Loading branch information
JoshuaKGoldberg authored Nov 26, 2024
1 parent fdc405f commit f27f90c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
4 changes: 0 additions & 4 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@ export default tseslint.config(
},
},
},
{
extends: [tseslint.configs.disableTypeChecked],
files: ["**/*.md/*.ts"],
},
{
extends: [vitest.configs.recommended],
files: ["**/*.test.*"],
Expand Down
14 changes: 9 additions & 5 deletions script/__snapshots__/migrate-test-e2e.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -162,18 +162,22 @@ exports[`expected file changes > eslint.config.js 1`] = `
"logical-assignment-operators": [
"error",
@@ ... @@ export default tseslint.config(
{
extends: [tseslint.configs.disableTypeChecked],
files: ["**/*.md/*.ts"],
},
},
},
+ {
+ extends: [tseslint.configs.disableTypeChecked],
+ files: ["**/*.md/*.ts"],
+ rules: {
+ "n/no-missing-import": [
+ "error",
+ { allowModules: ["create-typescript-app"] },
+ ],
+ },
},
+ },
{
extends: [vitest.configs.recommended],"
extends: [vitest.configs.recommended],
files: ["**/*.test.*"],"
`;
exports[`expected file changes > knip.json 1`] = `
Expand Down

0 comments on commit f27f90c

Please sign in to comment.