🛠 Tooling: Migration end-to-end test should use --guide and --guide-title
#1091
Labels
area: tooling
Managing the repository's maintenance
good first issue
Good for newcomers, please hop on!
status: accepting prs
Please, send a pull request to resolve this!
type: cleanup
Tech debt or other code/repository cleanups
Milestone
Bug Report Checklist
main
branch of the repository.Overview
The optional
--guide
and--guide-title
options were added in #982 -> #983. They add a little text blurb to the top ofDEVELOPMENT.md
:create-typescript-app/.github/DEVELOPMENT.md
Lines 3 to 4 in d66379b
But, the end-to-end migration test isn't running with them:
create-typescript-app/script/migrate-test-e2e.js
Line 14 in d66379b
Let's add
--guide
and--guide-title
to the end-to-end test's command. That way the generated.github/DEVELOPMENT.md
will also have the guided walkthrough notice.Additional Info
This repository is two things:
For the most part, the repository's end-to-end test for
--mode migration
makes sure that the 🍎 actual files and 🍌 code templates stay the same. As in, if one changes, the other needs to have the same change as well. But per #546, there are some files that were missed in that test. We're only now able to verify that they're the same as of #1048. That PR is where this discrepancy was discovered.The text was updated successfully, but these errors were encountered: