feat: sort-order rule shouldn't change sub-keys, better auto-fix #312
Conversation
hyoban
changed the title
|
@JoshuaKGoldberg Sorry for the direct ping, I don't want you to miss this one. Please feel free to review it when you have time. |
There was a problem hiding this comment.
This looks great, thanks! Just the one testing request. 🚀
Also - I think this is a big enough change (new dependencies, better auto-fix) that even though it's technically a bugfix, I'd like it to give it as a minor release rather than a patch. Renaming to feat: ....
There was a problem hiding this comment.
[Testing] Could you add a valid case where the top-level keys are sorted but sub-keys aren't? That way we know the logic is still just looking at the top-level keys.
| return fixer.replaceText( | ||
| context.sourceCode.ast, | ||
| JSON.stringify(orderedSource, null, 2) + | ||
| `\n`, | ||
| result, |
There was a problem hiding this comment.
[Praise] Nice, this results in better-preserved formatting for all auto-fixes!
|
Thanks for the ping! I've been in and out of being swamped with ESLint v9 / typescript-eslint v8 work, just emerging from that cocoon now. 😄 |
JoshuaKGoldberg
added
the
status: waiting for author
hyoban
changed the title
github-actions
bot
removed
the
status: waiting for author
|
🎉 This is included in version v0.13.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prsOverview