Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip pending request if new content is set #27

Merged
merged 2 commits into from
Mar 28, 2017
Merged

Skip pending request if new content is set #27

merged 2 commits into from
Mar 28, 2017

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Mar 23, 2017

@tomalec tomalec requested a review from warpech March 23, 2017 17:09
@tomalec
Copy link
Member Author

tomalec commented Mar 23, 2017

(the tests are failing due to lack of Juicy/juicy-html#24)

@tomalec
Copy link
Member Author

tomalec commented Mar 27, 2017

@warpech I have added changes related to your comments for Juicy/juicy-html#24

warpech
warpech approved these changes Mar 27, 2017
View reviewed changes
Copy link
Contributor

@warpech warpech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tomalec tomalec merged commit 4384a5c into master Mar 28, 2017
@tomalec tomalec deleted the skip-when-url-changed branch October 6, 2017 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warpech warpech warpech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomalec @warpech