Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jp/zernike partials #150

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ioannisPApapadopoulos
Copy link
Member

I managed to implement the partial derivatives with respect to y. The following code now runs:

`using MultivariateOrthogonalPolynomials

W = Weighted(Zernike(1))
Δ = Laplacian(axes(W,1))

∂ʸ = PartialDerivative{2}(axes(W,1))

Z⁰ = Zernike(0)
Z¹ = Zernike(1)

∂Y² = (Z¹ \ (∂ʸ * Z⁰)) * (Z⁰ \ (∂ʸ * W))
Δ = Z¹ \ (Laplacian(axes(W,1)) * W)

z=2.0; A = (∂Y² - z*Δ);
c = A[Block.(1:50), Block.(1:50)] \ rand(1275)`

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: -0.05 ⚠️

Comparison is base (02b1216) 96.21% compared to head (b80a9a4) 96.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   96.21%   96.17%   -0.05%     
==========================================
  Files           6        6              
  Lines         846      888      +42     
==========================================
+ Hits          814      854      +40     
- Misses         32       34       +2     
Impacted Files Coverage Δ
src/MultivariateOrthogonalPolynomials.jl 100.00% <ø> (ø)
src/disk.jl 97.16% <95.23%> (-0.48%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/disk.jl Outdated Show resolved Hide resolved
src/disk.jl Outdated Show resolved Hide resolved
src/disk.jl Outdated Show resolved Hide resolved
src/disk.jl Outdated Show resolved Hide resolved
src/disk.jl Outdated Show resolved Hide resolved
@ioannisPApapadopoulos
Copy link
Member Author

Windows tests are failing but that seems to be the case in the main branch as well. Not sure why the code coverage has decreased.. I'm covering the lines that it's complaining about in the tests.

@TSGut
Copy link
Member

TSGut commented May 29, 2023

I've noticed in other packages that the macro @simplify screws with coverage. I don't know why but as far as I've seen those lines never satisfy the coverage checks.

src/disk.jl Outdated Show resolved Hide resolved
src/disk.jl Outdated Show resolved Hide resolved
src/disk.jl Outdated Show resolved Hide resolved
src/disk.jl Outdated Show resolved Hide resolved
ioannisPApapadopoulos and others added 3 commits June 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants