-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #210
Updates #210
Conversation
There seem to be quite a few somewhat unrelated changes in this PR. Could you split this into multiple PRs, so that it'll be easy to keep track of them? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
===========================================
+ Coverage 99.88% 100.00% +0.11%
===========================================
Files 7 5 -2
Lines 871 620 -251
===========================================
- Hits 870 620 -250
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
Is this needed anymore? |
Yes. There is still an unfiled change. |
There is no feature change though, I think. Most are reorganising codes |
_fill_dot
support general vectors #229