Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #210

Closed
wants to merge 8 commits into from
Closed

Updates #210

wants to merge 8 commits into from

Conversation

putianyi889
Copy link
Contributor

@putianyi889 putianyi889 commented Mar 5, 2023

@jishnub
Copy link
Member

jishnub commented Mar 6, 2023

There seem to be quite a few somewhat unrelated changes in this PR. Could you split this into multiple PRs, so that it'll be easy to keep track of them?

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fef31cd) 99.88% compared to head (0abb814) 100.00%.
Report is 6 commits behind head on master.

❗ Current head 0abb814 differs from pull request most recent head 157b6c5. Consider uploading reports for the commit 157b6c5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #210      +/-   ##
===========================================
+ Coverage   99.88%   100.00%   +0.11%     
===========================================
  Files           7         5       -2     
  Lines         871       620     -251     
===========================================
- Hits          870       620     -250     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@putianyi889 putianyi889 marked this pull request as draft March 28, 2023 12:08
@dlfivefifty
Copy link
Member

Is this needed anymore?

@putianyi889
Copy link
Contributor Author

Yes. There is still an unfiled change.

@putianyi889
Copy link
Contributor Author

There is no feature change though, I think. Most are reorganising codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants