generalise Zero/Fill +/- using Requires.jl #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
putianyi889
commented
Mar 29, 2023
•
putianyi889
commented
- Support structured array types #223
|
@jishnub Can you add more ambiguity tests that you know of? |
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 99.21% 99.22% +0.01%
==========================================
Files 4 5 +1
Lines 633 642 +9
==========================================
+ Hits 628 637 +9
Misses 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'll strongly advise against this, as Requires messes with precompilation. Package extensions are the recommend workflow |
|
In any case, perhaps it's better to not go for such hasty piecemeal fixes before 1.0. Since this isn't breaking, we can include this after a stable release |
|
I agree with @jishnub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.