Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show eltype for Zeros/Ones #283

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 25, 2023

This changes the way Zeros and Ones are displayed compactly:
On master

julia> (Zeros{Int}(2),)
(Zeros(2),)

This PR

julia> (Zeros{Int}(2),)
(Zeros{Int64}(2),)

After this, the output represents a valid constructor for the displayed object.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #283 (2e0ed3b) into master (41715aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           5        5           
  Lines         851      857    +6     
=======================================
+ Hits          850      856    +6     
  Misses          1        1           
Files Changed Coverage Δ
src/FillArrays.jl 99.73% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty
Copy link
Member

I disagree this is need. The current behaviour is much easier to read

@jishnub
Copy link
Member Author

jishnub commented Jul 26, 2023

This makes it much easier to debug. While the current behaviour is easier to read, the convenience of copying and pasting output is significant, especially downstream

@dlfivefifty
Copy link
Member

oh sorry I misunderstood what this was doing.

@dlfivefifty dlfivefifty merged commit 9a7214e into JuliaArrays:master Jul 26, 2023
25 checks passed
@jishnub jishnub deleted the showzerosones branch July 26, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants