Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize isbanded for OneElement #333

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Specialize isbanded for OneElement #333

merged 3 commits into from
Jul 21, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 22, 2023

This allows O(1) checks for the bandedness of a OneElement.

julia> A = OneElement(3, (20,20), (20,20));

julia> @btime isdiag($A);
  542.590 ns (0 allocations: 0 bytes) # master
  3.382 ns (0 allocations: 0 bytes) # PR

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (4bfbeec) to head (6902fcc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           8        8           
  Lines        1086     1095    +9     
=======================================
+ Hits         1085     1094    +9     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@longemen3000
Copy link

seems a nice addition to have. i dont see any problems with it at first glance.

@jishnub jishnub requested a review from dlfivefifty July 9, 2024 08:30
@jishnub jishnub merged commit a7ddcca into master Jul 21, 2024
18 checks passed
@jishnub jishnub deleted the jishnub/oneeltrilu branch July 21, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants