Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change downstream tests fail fast to false #337

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 8, 2024

This should indicate the exact number of downstream packages that are broken by a change.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7c34aa) 99.89% compared to head (338009f) 99.89%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files           8        8           
  Lines         920      934   +14     
=======================================
+ Hits          919      933   +14     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member Author

jishnub commented Jan 9, 2024

Test failures are unrelated, so this should be good to merge

@jishnub jishnub merged commit 6b69b81 into master Jan 9, 2024
21 checks passed
@jishnub jishnub deleted the jishnub-patch-2 branch January 9, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant