Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize LinearAlgebra.symmetric for AbstractFill #372

Closed
wants to merge 2 commits into from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 16, 2024

This is used in places in LinearAlgebra, and currently

julia> F = Fill(3, 4, 4)                                                          
4×4 Fill{Int64}, with entries equal to 3

julia> LinearAlgebra.symmetric(F)                                                 
4×4 Symmetric{Int64, Fill{Int64, 2, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}}}}:
 3  3  3  3
 3  3  3  3
 3  3  3  3
 3  3  3  3

However, since a Fill is symmetric, we may avoid the wrapper and obtain

julia> LinearAlgebra.symmetric(F)                                                 
4×4 Fill{Int64}, with entries equal to 3

This helps ensure type-stability.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (f659d9f) to head (f66544b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           8        8           
  Lines        1106     1108    +2     
=======================================
+ Hits         1105     1107    +2     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub marked this pull request as draft August 16, 2024 13:05
@jishnub jishnub closed this Aug 21, 2024
@jishnub jishnub deleted the jishnub/symmetric branch August 21, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant