Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specialize Base._reshape #374

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Don't specialize Base._reshape #374

merged 2 commits into from
Aug 20, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 18, 2024

The specialized methods seem to merely call fill_reshape, so there is no need to specialize this internal function. We may directly call fill_reshape instead.

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (f659d9f) to head (260fef9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           8        8           
  Lines        1106     1110    +4     
=======================================
+ Hits         1105     1109    +4     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member Author

jishnub commented Aug 19, 2024

Looks like #369 has introduced ambiguities that now need to be resolved (was expected in hindsight)

@jishnub
Copy link
Member Author

jishnub commented Aug 20, 2024

Should be good to go now

@dlfivefifty dlfivefifty merged commit 9868632 into master Aug 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants