-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to PrecompileTools #1187
Move to PrecompileTools #1187
Conversation
ba4c91f
to
eacdf46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Co-Authored-By: Tim Holy <[email protected]>
d162b51
to
ef259d0
Compare
|
src/precompile.jl
Outdated
zeros(y) | ||
zeros(x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timholy see error above. I guessed
zeros(y) | |
zeros(x) | |
zeros(T, y) | |
zeros(T, x) |
but hit
ERROR: LoadError: MethodError: no method matching zeros(::Type{Float32}, ::StaticArraysCore.SVector{2, Float32})
Closest candidates are:
zeros(::Type{T}, ::Union{Integer, AbstractUnitRange}...) where T
@ Base array.jl:580
zeros(::Type{T}, ::Tuple{}) where T
@ Base array.jl:588
zeros(::Type{T}, ::Tuple{Vararg{Integer, N}}) where {T, N}
@ Base array.jl:583
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, should be zero
not zeros
. Sorry 'bout that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np. thanks
Co-Authored-By: Tim Holy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case I don't notice, someone should merge this when tests pass (nightly is now failing for a different reason having to do with nicer @code_llvm
output; if one snips after the first \n
I think that will fix that bug).
I just scrolled by and figured I could give a ping: @timholy |
Can someone rerun nightly CI |
The CI failure on nightly seems unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1184
Fixes #1182
Closes #1183
@timholy would you mind helping me figure out the commented out ones?