Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tf2ss conversion #971

Merged
merged 4 commits into from
Feb 14, 2025
Merged

improve tf2ss conversion #971

merged 4 commits into from
Feb 14, 2025

Conversation

baggepinnen
Copy link
Member

by using MatrixPencils, which offers possibility of constructing a minimal realization. This option is much faster than the old approach minreal(ss(P)) for large systems

by using MatrixPencils, which offers possibility of constructing a minimal realization. This option is _much_ faster than the old approach `minreal(ss(P))` for large systems
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 1/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.006 Reference New

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (c66b3d1) to head (aba649d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
- Coverage   92.83%   92.60%   -0.23%     
==========================================
  Files          41       41              
  Lines        5007     4973      -34     
==========================================
- Hits         4648     4605      -43     
- Misses        359      368       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baggepinnen baggepinnen merged commit c1cf26a into master Feb 14, 2025
4 of 5 checks passed
@baggepinnen baggepinnen deleted the tf2ss branch February 14, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants