Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tzeros for BigFloat #976

Merged
merged 1 commit into from
Feb 25, 2025
Merged

enable tzeros for BigFloat #976

merged 1 commit into from
Feb 25, 2025

Conversation

baggepinnen
Copy link
Member

Unfrotunately, this brings back the old implementation of tzeros due to MatrixPencils relying too much on BLAS to work on generic numbers

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 1/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.005 Reference New

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 92.10526% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.41%. Comparing base (5c6f583) to head (88f3187).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/ControlSystemsBase/src/analysis.jl 92.95% 5 Missing ⚠️
lib/ControlSystemsBase/src/ControlSystemsBase.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   92.28%   92.41%   +0.12%     
==========================================
  Files          41       41              
  Lines        4911     4981      +70     
==========================================
+ Hits         4532     4603      +71     
+ Misses        379      378       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baggepinnen baggepinnen merged commit 948a6b4 into master Feb 25, 2025
5 of 6 checks passed
@baggepinnen baggepinnen deleted the bigfloatzeros branch February 25, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants