-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer DualNumbers implementation from ForwardDiff #49
base: master
Are you sure you want to change the base?
Conversation
I think we should definitely try to keep the git history for these files. |
Thanks @ranjanan. Before you go down this route, be warned that it will probably involve a good bit of work and digging into the implementation details of both packages. I had planned on doing this work myself after v0.6 released to avoid having to continuously update with breakage/depwarn fixes. We need the change-over to not merely swap out the old implementation for ForwardDiff's, but to ensure that the feature sets of the two implementations are appropriately merged. We'll wish to drop some of the old behaviors, while other behaviors we'll wish to preserve, probably requiring new definitions. For example, there are some primitives defined on Things that have to be done (besides just porting over the code):
I'd also like my name added to the LICENSE (and I believe @mlubin is also within his rights to request this, but I'll let him speak for himself). I believe doing this requires Theo's permission? Some comments on this PR as it is:
|
[ci skip]
@jrevels Thank you for your comments. I shall work to complete those objectives. I'd be most grateful if you would comment as and when you see something worth discussing, such as an API that's being deprecated, etc. |
Go back to original ForwardDiff's Dual pretty printing
[ci skip]
[ci skip]
* conjdual * absdual * abs2dual [ci skip]
[ci skip]
Seems to be failing because of travis-ci/travis-ci#4942, adding the following fix (travis-ci/travis-ci#4942 (comment)) to |
This fails because the function |
What is the status of this PR? Is this just waiting for resolving the conflicts? |
Well, I looked at #45, so I thought this PR might help. The code is basically the same, but I exported
Dual
,value
andpartials
. I also added pretty printing, so Dual Numbers would look like: